fix(bundler-plugins): integration with monorepo#21342
Open
isaacs wants to merge 737 commits into
Open
Conversation
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
…ludeTracing` (#644) Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
This reverts commit 8eb6c5f.
Revert the default behaviour of the webpack plugin to no longer exit the process. Instead, users can set an experimental flag to force exiting the process.
…terUpload` (#677) Widen the accepted type for `filesToDeleteAfterSourcemaps` to allow us (as well as users) to pass in a `Promise<string | string[]>` to do so. This promise can resolve whenever we know what to set and we await the promise before calling `glob` to get all file paths to delete.
Update changelog for 3.2.0
Upgrade sentry-cli to [2.58.6](https://github.com/getsentry/sentry-cli/releases/tag/2.58.6), which includes security fixes.
Consolidate all bundler plugin code into a single new `@sentry/bundler-plugins` package with subpath exports (`/rollup`, `/webpack`, `/vite`, etc.). Code was moved using `git mv` to preserve history. The existing bundler-specific packages (`@sentry/rollup-plugin`, etc.) become thin stubs that re-export from `@sentry/bundler-plugins`. This makes it straightforward to: - Add new bundler support (e.g. rolldown) without publishing a new package - Move all plugin code in the JS monorepo as a single dependency rather than 6 - Keep bundler-specific packages at v5, avoiding unnecessary major version bumps for users Individual packages can eventually be deprecated but there's no urgency — integration tests still target them and they remain fully functional.
- Remove all contents that are not going to be ported to the sentry-javascript monorepo. - Move the integration tests into a suitable location.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/in/1153895?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
2da5301 to
936498f
Compare
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
936498f to
8046230
Compare
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
8046230 to
4008b69
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
4008b69 to
1fe3d0c
Compare
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
1fe3d0c to
6882d3e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6882d3e. Configure here.
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
2 times, most recently
from
2420de2 to
a37151b
Compare
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
a37151b to
2d30000
Compare
Integrate the newly merged in `@sentry/bundler-plugins` project to the sentry-javascript monorepo. - Integration tests are updated to use the named submodule exports on the `@sentry/bundler-plugins` package, rather than the per-platform re-export shims. - Lint and naming conventions brought in line with project standards. - Bundler-plugins integration tests now run on CI. - Aligned on the same vitest version for bundler-plugins and the rest of the repo. It might be good to upgrade vitest, but not needed for this merge. The version has not been updated from its independent 5.x line, though it may be a good idea to bump it up to align with the 10.x line that the rest of the monorepo uses.
isaacs
force-pushed
the
feat/merge-in-sentry-javascript-bundler-plugins
branch
from
2d30000 to
239808f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the commit log in this PR is ridiculous, because it intentionally preserves the history of the sentry-javascript-bundler-plugins repo. Probably best to review locally. Attempting to do a rebase or squash merge will probably break GitHub and maybe the world 😅
Integrate the newly merged in
@sentry/bundler-pluginsproject to thesentry-javascript monorepo.
the
@sentry/bundler-pluginspackage, rather than the per-platformre-export shims.
The version has not been updated from its independent 5.x line, though
it may be a good idea to bump it up to align with the 10.x line that the
rest of the monorepo uses.